Removing hard-coded backslashes#4
Open
hakanai wants to merge 1 commit intoSmithsGaming:Development-1.9from
Open
Removing hard-coded backslashes#4hakanai wants to merge 1 commit intoSmithsGaming:Development-1.9from
hakanai wants to merge 1 commit intoSmithsGaming:Development-1.9from
Conversation
Hard-coded backslashes caused creation of file called "config\armory\Addons\weaponry.cfg" in the root directory instead of putting the file in config/armory/Addons, when running on any OS other than Windows. Forward slashes work fine for all platforms in Java and thus is the obvious fix. I have not checked other files in the repository for the same bug.
Author
|
Build on Travis-CI failed, but due to some kind of external issue. |
Member
|
Hello I am currently moving the Repo's to MineColonies, which also includes updating the BuildSystem, which is why you cannot build the PR. I will make sure that this PR gets included in the last release for 1.10 before i release the 1.11 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hard-coded backslashes caused creation of file called "config\armory\Addons\weaponry.cfg" in the root directory instead of putting the file in config/armory/Addons, when running on any OS other than Windows. Forward slashes work fine for all platforms in Java and thus is the obvious fix.
I have not checked other files in the repository for the same bug.